Update Selection Panels to be in-view aware #9631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitrox
commented
Nov 7, 2024
There was a problem hiding this comment.
This will be removed when #9630 will be merged.
|
Build files for 0c3c078 are ready:
|
|
Size Change: +401 B (+0.02%) Total Size: 1.88 MB
ℹ️ View Unchanged
|
nfmohit
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Brilliant work on this, @ankitrox, thank you! Please see the following notes:
- In the QAB, it might be worth specifying the following AC:
The flicker that PR #7779 fixed in the Metrics Selection Panel should not return as a result of these changes.
- Additionally, I think it might also be worth doing a
QA:Engon this one in addition to general QA to ensure the following AC is met:
An observable result of this is that the panels should not trigger any API requests upon page load, unless the request is explicitly determined to be required.
- I've left a few comments in the code, please take a look, thank you!
Please let me know if you have any questions, thanks!
| } ) } | ||
| <InViewProvider | ||
| value={ { | ||
| key: 'WPDashboardApp', |
There was a problem hiding this comment.
Suggested change
| key: 'WPDashboardApp', | |
| key: 'MetricsSelectionPanel', |
| <InViewProvider | ||
| value={ { | ||
| key: 'AudienceSelectionPanel', | ||
| value: isOpen, |
There was a problem hiding this comment.
Do you think it would be a good idea to enforce a boolean value here, since core/ui getValue can return undefined if it can't find the key?
Suggested change
| value: isOpen, | |
| value: !! isOpen, |
| .dispatch( MODULES_ANALYTICS_4 ) | ||
| .receiveError( error, storeFunctionName, args ); | ||
|
|
||
| afterEach( async () => { |
There was a problem hiding this comment.
I think I understand what you're doing here, but this feels quite unorthodox compared to how we usually compose tests, namely:
- We usually do not do assertions in
beforeEachorafterEach. - All test cases usually read as natural language, e.g. "it should do something".
Could you possibly enlighten why we can't stick to the previous it.each() approach which was much cleaner?
Comment on lines
1798
to
1810
| describe( 'should display an error message', () => { | ||
| const error = { | ||
| code: 'test_error', | ||
| message: 'Error message.', | ||
| data: {}, | ||
| }; | ||
|
|
||
| beforeEach( () => { | ||
| provideModules( registry ); | ||
| provideModuleRegistrations( registry ); | ||
| } ); | ||
|
|
||
| afterEach( async () => { |
| /** | ||
| * Selection Panel | ||
| * | ||
| * Site Kit by Google, Copyright 2023 Google LLC |
There was a problem hiding this comment.
Very nitpicky, but as this is a newer component, should we update the year?
Suggested change
| * Site Kit by Google, Copyright 2023 Google LLC | |
| * Site Kit by Google, Copyright 2024 Google LLC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
useInViewSelect()hook where applicable #9312Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist