Add first party mode datastore. #9642
Open
+561
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 91da16e are ready:
|
|
Size Change: +364 B (+0.02%) Total Size: 1.88 MB
ℹ️ View Unchanged
|
2 tasks
techanvil
reviewed
Nov 11, 2024
techanvil
force-pushed
the
enhancement/9628-first-party-mode-datastore
branch
from
abd3121
to
8709b75
Compare
techanvil
force-pushed
the
enhancement/9628-first-party-mode-datastore
branch
from
8709b75
to
f6712b6
Compare
hussain-t
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Thanks, @techanvil. This almost looks good. However, I've left a couple of comments for your review.
| */ | ||
| setFirstPartyModeEnabled() { | ||
| return { | ||
| type: SET_FIRST_PARTY_MODE_ENABLED, |
There was a problem hiding this comment.
Can we return a payload property?
Suggested change
| type: SET_FIRST_PARTY_MODE_ENABLED, | |
| type: SET_FIRST_PARTY_MODE_ENABLED, | |
| payload: { isEnabled }, |
There was a problem hiding this comment.
Thanks for spotting that, @hussain-t! I've updated it to provide a payload 👍
| switch ( type ) { | ||
| case SET_FIRST_PARTY_MODE_ENABLED: { | ||
| state.firstPartyModeSettings = state.firstPartyModeSettings || {}; | ||
| state.firstPartyModeSettings.isEnabled = true; |
There was a problem hiding this comment.
Can we set it from the payload instead of hardcoding it?
|
|
||
| const baseControls = {}; | ||
|
|
||
| const baseReducer = createReducer( ( state, { type } ) => { |
There was a problem hiding this comment.
Suggested change
| const baseReducer = createReducer( ( state, { type } ) => { | |
| const baseReducer = createReducer( ( state, { type, payload } ) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist