Fix: Success banners remain present when the Audience Segmentation fe… #9681
+89
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature is disabled.
|
Build files for 13ad7fa are ready:
|
|
Size Change: +262 B (+0.01%) Total Size: 1.88 MB
ℹ️ View Unchanged
|
nfmohit
requested changes
Nov 14, 2024
Comment on lines
+271
to
+277
| await act( async () => { | ||
| await registry | ||
| .dispatch( CORE_USER ) | ||
| .receiveGetDismissedItems( [ | ||
| SETTINGS_VISITOR_GROUPS_SETUP_SUCCESS_NOTIFICATION, | ||
| ] ); | ||
| } ); |
There was a problem hiding this comment.
I'm having trouble understanding what this block actually does. Doesn't this make the test case technically wrong as the dismissal won't be trigger if it is already dismissed? I think in a general scenario this test would fail.
I've tried removing this and the test still passes, which I think is more appropriate.
Suggested change
| await act( async () => { | |
| await registry | |
| .dispatch( CORE_USER ) | |
| .receiveGetDismissedItems( [ | |
| SETTINGS_VISITOR_GROUPS_SETUP_SUCCESS_NOTIFICATION, | |
| ] ); | |
| } ); |
| @@ -16,10 +16,15 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| /** | |||
| * External dependencies | |||
There was a problem hiding this comment.
Nitpicky, but while we're at it:
Suggested change
| * External dependencies | |
| * WordPress dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ature is disabled.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist