Enhancement/9621 update siwg client id url #9689
Open
+218
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for d124ff9 are ready:
|
|
Size Change: +152 B (+0.01%) Total Size: 1.88 MB
ℹ️ View Unchanged
|
aaemnnosttv
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Thanks @jimmymadon – this looks great overall, just a few comments and one change that just came in that makes more sense to do here than separately.
| const query = { | ||
| appname: siteName, | ||
| sitename: siteName, | ||
| siteurl: homeURL, |
There was a problem hiding this comment.
Sorry for the change here, but we need to pass the origin here instead. Essentially:
Suggested change
| siteurl: homeURL, | |
| siteorigin: new URL( homeURL ).origin, |
Comment on lines
+71
to
+78
| * Gets a URL to fetch the client ID. | ||
| * | ||
| * @since n.e.x.t | ||
| * | ||
| * @param {Object} state Data store's state. | ||
| * @return {(string|undefined)} The URL to the clientID, or `undefined` if not loaded. | ||
| */ | ||
| getClientIDURL: createRegistrySelector( ( select ) => () => { |
There was a problem hiding this comment.
Not a bad idea to give this a dedicated selector but we generally name these using a getService*URL to indicate the URL is based on the serviceURL. Maybe getServiceClientIDProvisioningURL while a bit long would be much more clear :) WDYT?
| */ | ||
| getClientIDURL: createRegistrySelector( ( select ) => () => { | ||
| const siteName = select( CORE_SITE ).getSiteName(); | ||
| const homeURL = untrailingslashit( select( CORE_SITE ).getHomeURL() ); |
There was a problem hiding this comment.
The trailing slash is irrelevant now given we only need the origin which wouldn't include any part of the path.
| @@ -86,6 +86,11 @@ it( 'ensures all serviceURLs are properly constructed', () => { | |||
| 'https://search.google.com/search-console/foo-path', | |||
| 'https://search.google.com/search-console/foo-path?bar=baz', | |||
| ], | |||
| 'modules/sign-in-with-google': [ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist