Indexing tests and fixes #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
indexing-errors
branch
from
c997c73 to
63c9935
Compare
thatch
reviewed
Sep 25, 2020
| def testOverflowError(self): | ||
| # For really big lists, we can't use the len() function any more | ||
| with self.assertRaises(OverflowError): | ||
| with self.assertRaises(OverflowError) as cm: |
Contributor
There was a problem hiding this comment.
assertRaisesRegex can do the message check in one line
Contributor
Author
There was a problem hiding this comment.
As the message strings are long, the single line syntax doesnt fit in a single line - and can look quite messy in a with.
Also the messages often change over time, while the Exception subclass and trigger logic usually does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.