Skip to content

Update custom numeric data types to use default constructor #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Dec 3, 2025
Merged

Update custom numeric data types to use default constructor #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tensorstore/util/bfloat16.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,7 @@ float Bfloat16ToFloat(BFloat16 v);
/// \ingroup Data types
class BFloat16 {
public:
/// Zero initialization.
///
/// \id zero
constexpr BFloat16() : rep_(0) {}
BFloat16() = default;

/// Possibly lossy conversion from any type convertible to `float`.
///
Expand Down
3 changes: 1 addition & 2 deletions tensorstore/util/float8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ class Float8Base {

public:
static constexpr int kBits = 8;

constexpr Float8Base() : rep_(0) {}
Float8Base() = default;

template <typename T>
explicit Float8Base(T i,
Expand Down
5 changes: 1 addition & 4 deletions tensorstore/util/int2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,7 @@ constexpr int8_t SignedTrunc2(int8_t x) {
/// \ingroup Data types
class Int2Padded {
public:
/// Zero initialization.
///
/// \id zero
constexpr Int2Padded() : rep_(0) {}
Int2Padded() = default;

/// Possibly lossy conversion from any type convertible to `int8_t`.
///
Expand Down
5 changes: 1 addition & 4 deletions tensorstore/util/int4.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,7 @@ constexpr int8_t SignedTrunc4(int8_t x) {
/// \ingroup Data types
class Int4Padded {
public:
/// Zero initialization.
///
/// \id zero
constexpr Int4Padded() : rep_(0) {}
Int4Padded() = default;

/// Possibly lossy conversion from any type convertible to `int8_t`.
///
Expand Down