Skip to content

Conversation

@bobhancockg
Copy link
Contributor

…iles:

This change introduces Python type hints and annotations to the following files:

  • google/ads/googleads/client.py
  • google/ads/googleads/config.py
  • google/ads/googleads/errors.py
  • google/ads/googleads/oauth2.py
  • google/ads/googleads/util.py

Type hints improve code readability and help with static analysis. I used typing.Any and # type: ignore where necessary to handle dynamic typing or external library interactions. No changes were needed for google/ads/googleads/__init__.py as it only contains imports and a version string.

@bobhancockg bobhancockg requested a review from a team as a code owner May 24, 2025 14:27
@bobhancockg bobhancockg changed the title Here's how I've added type annotations to your google/ads/googleads f… Added type annotations to your google/ads/googlead Jun 2, 2025
@bobhancockg bobhancockg changed the title Added type annotations to your google/ads/googlead Added type hints to google/ads/googleads Jun 2, 2025
@BenRKarl BenRKarl added the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@kokoro-team kokoro-team removed the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@BenRKarl BenRKarl added the kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@BenRKarl BenRKarl force-pushed the add-type-hints-to-googleads branch from c8584d6 to c538816 Compare September 30, 2025 15:49
@kokoro-team kokoro-team removed the kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Sep 30, 2025
google-labs-jules bot and others added 3 commits October 21, 2025 08:41
…iles:

This change introduces Python type hints and annotations to the following files:
- google/ads/googleads/client.py
- google/ads/googleads/config.py
- google/ads/googleads/errors.py
- google/ads/googleads/oauth2.py
- google/ads/googleads/util.py

Type hints improve code readability and help with static analysis. I used `typing.Any` and `# type: ignore` where necessary to handle dynamic typing or external library interactions. No changes were needed for `google/ads/googleads/__init__.py` as it only contains imports and a version string.
Change-Id: Id71fb41c9a190b37e6e7865c862e8865ddd04005
Change-Id: I861a4d620d0214946c17b5f1759cf65053dc1cd5
@BenRKarl BenRKarl force-pushed the add-type-hints-to-googleads branch from 6e61f52 to 45b812f Compare October 21, 2025 12:41
@BenRKarl BenRKarl added the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Oct 21, 2025
@kokoro-team kokoro-team removed the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Oct 21, 2025
@BenRKarl BenRKarl merged commit df5094d into main Oct 21, 2025
4 checks passed
@BenRKarl BenRKarl deleted the add-type-hints-to-googleads branch October 21, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants