chore(EventBuilder): remove reserved event validation #2263
Merged
lindsey-volta merged 3 commits intomainfrom Oct 7, 2025
Merged
chore(EventBuilder): remove reserved event validation #2263lindsey-volta merged 3 commits intomainfrom
lindsey-volta merged 3 commits intomainfrom
Conversation
lindsey-volta
changed the title
lindsey-volta
commented
Oct 3, 2025
jradcliff
reviewed
Oct 3, 2025
src/components/ga4/EventBuilder/ValidateEvent/handlers/formatCheckLib.ts
Outdated
Show resolved
Hide resolved
jradcliff
approved these changes
Oct 3, 2025
ikuleshov
approved these changes
Oct 7, 2025
appletorsh19-stack
referenced
this pull request
Nov 3, 2025
* allow in app purchase events for app streams * increase jest timeout * add comment explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the client-side validation for reserved event names in the Event Builder.
User only shown one validation error message if they try to incorrectly send a reserved event:Screenshots
Whereas previously, since the validation was happening locally and on the server side, the user saw duplicate messages.
