feat(storage): take async client out of experimental #15573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajajneha27
had a problem deploying
to
external
GitHub Actions
Error
product-auto-label
bot
added
the
api: storage
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15573 +/- ##
==========================================
- Coverage 93.10% 93.09% -0.01%
==========================================
Files 2418 2418
Lines 222268 222232 -36
==========================================
- Hits 206934 206897 -37
- Misses 15334 15335 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shubham-up-47
previously approved these changes
Oct 7, 2025
| return connection_ | ||
| ->Open({std::move(spec), | ||
| internal::MergeOptions(std::move(opts), connection_->options())}) | ||
| ->Open({std::move(spec), google::cloud::internal::MergeOptions( |
Contributor
There was a problem hiding this comment.
Why are we writing full namespace now?
Contributor
shubham-up-47
left a comment
shubham-up-47
left a comment
There was a problem hiding this comment.
Please search experimental and gcs_ex keywords in your local repo, so that we don't miss these words in any file.
Please fix the code coverage which are affected by these changes.
bajajneha27
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is