impl(v3): remove GCS grpc experimental shims

[scotthart]

Fixes #13857

This change is 

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant cleanup of the Google Cloud Storage (GCS) gRPC client implementation. It systematically removes deprecated experimental shims, specifically the GrpcPluginOption and DefaultGrpcClient from the storage_experimental namespace. This change also includes the removal of associated internal logic for conditional client creation and their corresponding unit tests. The overall impact is a more streamlined and maintainable codebase, free from outdated components.

Highlights

• Removal of Experimental GCS gRPC Shims: The storage_experimental::GrpcPluginOption struct and the storage_experimental::DefaultGrpcClient function, which were previously marked as deprecated, have been completely removed from the codebase.
• Simplified Client Creation Logic: The internal UseRest helper function and its conditional call within MakeGrpcClient have been removed, streamlining the logic for creating GCS clients.
• Test Cleanup: Several unit tests that relied on the removed experimental gRPC shims and their configuration options have been deleted, reducing test suite overhead and maintaining relevance.

Changelog

• google/cloud/storage/grpc_plugin.cc
  • Removed the UseRest helper function and its usage, which previously determined whether to use a REST client based on experimental options.
  • Deleted the implementation of storage_experimental::DefaultGrpcClient.
• google/cloud/storage/grpc_plugin.h
  • Removed the deprecated storage_experimental::GrpcPluginOption struct.
  • Removed the deprecated storage_experimental::DefaultGrpcClient function declaration.
• google/cloud/storage/grpc_plugin_test.cc
  • Deleted tests MostConfigValuesCreatesGrpc, EnvironmentOverrides, NoneConfigCreatesCurl, HybridUsesGrpcBufferOptions, and BackwardsCompatibilityShims that tested the removed experimental gRPC shims and their configuration options.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request provides a good cleanup by removing deprecated experimental shims related to GCS gRPC client creation. The changes simplify the MakeGrpcClient function, ensuring it exclusively creates gRPC clients, which improves code clarity and maintainability. The corresponding removal of deprecated options, functions, and tests is also handled correctly. The codebase is cleaner and more straightforward as a result of these changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.80%. Comparing base (e1d9216) to head (7265dcd).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15930   +/-   ##
===================================================
  Coverage               92.79%   92.80%           
===================================================
  Files                    2332     2332           
  Lines                  214386   214327   -59     
===================================================
- Hits                   198946   198909   -37     
+ Misses                  15440    15418   -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.