impl(v3): Multiplexed sessions always enabled

doc/v3-migration-guide.md

@@ -737,6 +737,21 @@ auto subscriber = pubsub::Subscriber(pubsub::MakeSubscriberConnection(
 
 ### Spanner
 
+<details>
+<summary>All sessions are now Multiplexed Sessions</summary>
+
+All SessionPool related options are marked deprecated and are now ignored by the
+Spanner library and will be removed in the future:
+
+- `EnableMultiplexedSessionOption`
+- `SessionPoolMinSessionsOption`
+- `SessionPoolMaxSessionsPerChannelOption`
+- `SessionPoolMaxIdleSessionsOption`
+- `SessionPoolActionOnExhaustionOption`
+- `SessionPoolKeepAliveIntervalOption`
+
+</details>
+
 <details>
 <summary>Removed <code>spanner::MakeTestRow</code>
 </summary>

google/cloud/spanner/README.md

@@ -18,6 +18,8 @@ this library.
 <!-- inject-quickstart-start -->
 
 ```cc
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
+
 #include "google/cloud/spanner/client.h"
 #include <iostream>
 
@@ -45,6 +47,7 @@ int main(int argc, char* argv[]) {
 
   return 0;
 }
+#include "google/cloud/internal/diagnostics_pop.inc"
 ```
 
 <!-- inject-quickstart-end -->

google/cloud/spanner/admin/integration_tests/backup_extra_integration_test.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/admin/database_admin_client.h"
 #include "google/cloud/spanner/admin/database_admin_options.h"
 #include "google/cloud/spanner/admin/instance_admin_client.h"
@@ -541,3 +541,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/admin/integration_tests/backup_integration_test.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/admin/database_admin_client.h"
 #include "google/cloud/spanner/admin/database_admin_options.h"
 #include "google/cloud/spanner/backoff_policy.h"
@@ -275,3 +275,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/admin/database_admin_client.h"
 #include "google/cloud/spanner/benchmarks/benchmarks_config.h"
 #include "google/cloud/spanner/client.h"
@@ -1434,3 +1434,4 @@ int main(int argc, char* argv[]) {
                                         : "database dropped\n");
   return exit_status;
 }
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/benchmarks/single_row_throughput_benchmark.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/admin/database_admin_client.h"
 #include "google/cloud/spanner/benchmarks/benchmarks_config.h"
 #include "google/cloud/spanner/client.h"
@@ -511,3 +511,4 @@ int main(int argc, char* argv[]) {
                                         : "database dropped\n");
   return 0;
 }
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/client.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/client.h"
 #include "google/cloud/spanner/internal/connection_impl.h"
 #include "google/cloud/spanner/internal/spanner_stub_factory.h"
@@ -432,3 +432,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/client_test.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/client.h"
 #include "google/cloud/mocks/mock_stream_range.h"
 #include "google/cloud/spanner/connection.h"
@@ -1339,3 +1339,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/commit_options.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/commit_options.h"
 #include "google/cloud/spanner/options.h"
 
@@ -48,3 +48,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/connection.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/connection.h"
 #include "google/cloud/spanner/query_partition.h"
 #include "google/cloud/spanner/read_partition.h"
@@ -115,3 +115,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/integration_tests/client_integration_test.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/admin/database_admin_client.h"
 #include "google/cloud/spanner/client.h"
 #include "google/cloud/spanner/database.h"
@@ -1769,3 +1769,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/integration_tests/client_stress_test.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/client.h"
 #include "google/cloud/spanner/database.h"
 #include "google/cloud/spanner/testing/database_integration_test.h"
@@ -148,6 +148,8 @@ TEST_F(ClientStressTest, ParseArgs) {
 
 /// @test Stress test the library using ExecuteQuery calls.
 TEST_F(ClientStressTest, UpsertAndSelect) {
+  // TODO(#15939): Update emulator and enable this test.
+  if (UsingEmulator()) GTEST_SKIP();
   int const task_count = TaskCount();
 
   auto select_task = [](Client client) {
@@ -216,6 +218,8 @@ TEST_F(ClientStressTest, UpsertAndSelect) {
 
 /// @test Stress test the library using Read calls.
 TEST_F(ClientStressTest, UpsertAndRead) {
+  // TODO(#15939): Update emulator and enable this test.
+  if (UsingEmulator()) GTEST_SKIP();
   int const task_count = TaskCount();
 
   auto read_task = [](Client client) {
@@ -302,3 +306,4 @@ int main(int argc, char* argv[]) {
 
   return RUN_ALL_TESTS();
 }
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/integration_tests/data_types_integration_test.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/admin/database_admin_client.h"
 #include "google/cloud/spanner/client.h"
 #include "google/cloud/spanner/database.h"
@@ -1003,3 +1003,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/integration_tests/session_pool_integration_test.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/internal/defaults.h"
 #include "google/cloud/spanner/internal/session_pool.h"
 #include "google/cloud/spanner/internal/spanner_stub_factory.h"
@@ -124,3 +124,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner_internal
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/internal/connection_impl.cc

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
+#include "google/cloud/internal/disable_deprecation_warnings.inc"
 #include "google/cloud/spanner/internal/connection_impl.h"
 #include "google/cloud/spanner/internal/defaults.h"
 #include "google/cloud/spanner/internal/logging_result_set_reader.h"
@@ -1446,3 +1446,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner_internal
 }  // namespace cloud
 }  // namespace google
+#include "google/cloud/internal/diagnostics_pop.inc"