Skip to content

ci: code updates to get windows builds working#16178

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:msvc_fixes_202606
Jun 17, 2026
Merged

ci: code updates to get windows builds working#16178
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:msvc_fixes_202606

Conversation

@scotthart

@scotthart scotthart commented Jun 16, 2026

Copy link
Copy Markdown
Member

This PR makes the necessary code updates to allow MSVC to build the SDK. Several issues were created to track tests that were disabled in windows. Another issue was created to determine if GDCH credentials support is required on Windows.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables several tests on Windows/MSVC due to compatibility issues, updates HTTP header string construction to use absl::StrCat, and modifies a lambda capture in oauth2_regional_access_boundary_token_manager.h. The review feedback highlights a critical issue with the lambda capture: using default capture by value [=] implicitly captures this in an asynchronous context, which can lead to use-after-free bugs. It is recommended to explicitly capture only the required variables and use std::move to avoid unnecessary copies of the request object.

Comment thread google/cloud/internal/oauth2_regional_access_boundary_token_manager.h Outdated
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (a82ff3b) to head (9f1dcc2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16178      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.01%     
==========================================
  Files        2265     2265              
  Lines      209832   209832              
==========================================
- Hits       193534   193527       -7     
- Misses      16298    16305       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit 590dcc6 into googleapis:main Jun 17, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants