Skip to content

ci: use sccache v.0.14.0 with C++20#16182

Closed
scotthart wants to merge 0 commit into
googleapis:mainfrom
scotthart:ci_cxx20_sccache
Closed

ci: use sccache v.0.14.0 with C++20#16182
scotthart wants to merge 0 commit into
googleapis:mainfrom
scotthart:ci_cxx20_sccache

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades the sccache version from 0.15.0 to 0.14.0 in the Fedora C++20 Dockerfile. The reviewer suggested defining the version string using an ARG instruction rather than hardcoding it directly in the RUN command to improve maintainability.


WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.15.0/sccache-v0.15.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and adhere to the repository's best practices, use an ARG to define version strings in Dockerfiles rather than hardcoding them directly in the RUN commands. This makes it easier to manage and update versions consistently.

ARG SCCACHE_VERSION=0.14.0
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v${SCCACHE_VERSION}/sccache-v${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (590dcc6) to head (9c4d8b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16182      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.01%     
==========================================
  Files        2265     2265              
  Lines      209832   209832              
==========================================
- Hits       193534   193527       -7     
- Misses      16298    16305       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants