ci: use sccache v.0.14.0 with C++20#16182
Conversation
There was a problem hiding this comment.
Code Review
This pull request downgrades the sccache version from 0.15.0 to 0.14.0 in the Fedora C++20 Dockerfile. The reviewer suggested defining the version string using an ARG instruction rather than hardcoding it directly in the RUN command to improve maintainability.
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.15.0/sccache-v0.15.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.14.0/sccache-v0.14.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and adhere to the repository's best practices, use an ARG to define version strings in Dockerfiles rather than hardcoding them directly in the RUN commands. This makes it easier to manage and update versions consistently.
ARG SCCACHE_VERSION=0.14.0
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v${SCCACHE_VERSION}/sccache-v${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16182 +/- ##
==========================================
- Coverage 92.23% 92.22% -0.01%
==========================================
Files 2265 2265
Lines 209832 209832
==========================================
- Hits 193534 193527 -7
- Misses 16298 16305 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9c4d8b2 to
5a2de69
Compare
No description provided.