Skip to content

ci: use sccache v0.10.0 with C++20#16183

Merged
scotthart merged 1 commit into
googleapis:mainfrom
scotthart:ci_cxx20_sccache
Jun 17, 2026
Merged

ci: use sccache v0.10.0 with C++20#16183
scotthart merged 1 commit into
googleapis:mainfrom
scotthart:ci_cxx20_sccache

Conversation

@scotthart

@scotthart scotthart commented Jun 17, 2026

Copy link
Copy Markdown
Member

After upgrading to sccache v0.15.0, the cxx-20 build time tripled. I don't have a good explanation for why this occurred, but the increased time began on the next commit after upgrading to v0.15.0 from v0.10.0. We will continue to monitor the build time after this PR is merged to determine if reverting the sccache version helped.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades the sccache version from v0.15.0 to v0.10.0 in the Fedora Dockerfile. The reviewer suggested using an ARG to define the sccache version string to improve maintainability and avoid duplication.


WORKDIR /var/tmp/sccache
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.15.0/sccache-v0.15.0-x86_64-unknown-linux-musl.tar.gz | \
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplication, use an ARG to define the sccache version string. This aligns with our practice of defining version strings in Dockerfiles using ARG so they can be easily managed and updated.

ARG SCCACHE_VERSION=0.10.0
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v${SCCACHE_VERSION}/sccache-v${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

@scotthart scotthart marked this pull request as ready for review June 17, 2026 20:32
@scotthart scotthart requested a review from a team as a code owner June 17, 2026 20:32
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (ccd7e7f) to head (67ca4dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16183      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.01%     
==========================================
  Files        2265     2265              
  Lines      209832   209832              
==========================================
- Hits       193529   193527       -2     
- Misses      16303    16305       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) June 17, 2026 20:50
@scotthart scotthart merged commit 3612064 into googleapis:main Jun 17, 2026
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants