-
Notifications
You must be signed in to change notification settings - Fork 94
docs(guide): friction log fixes #3233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| cargo add google-cloud-aiplatform-v1 --no-default-features --features prediction-service | ||
| ``` | ||
|
|
||
| If you are using cloud shell (or have limited disk space), you might see a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {{#include ../samples/src/gemini.rs:prompt-and-image}} | ||
| ``` | ||
|
|
||
| Note: These code samples return `crate::Result<()>` for the sake of brevity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 125 125
Lines 5027 5027
=======================================
Hits 4825 4825
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Note: These code samples return `crate::Result<()>` for the sake of brevity. You | ||
| will need to change the return type to | ||
| `std::result::Result<(), Box<dyn std::error::Error>>` since your project | ||
| structure is likely different from that of the samples. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... projects may use anyhow::Result<()> or the Box thing ... or their own error that wraps our error as a source.
Maybe we should change all the code to use anyhow::Result<()>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's convenient, I replaced the crate::Result<()> with anyhow::Result<()>
| If you are using cloud shell (or have limited disk space), you might see a "no | ||
| space left on device" error. Run the following to remove build artifacts: | ||
|
|
||
| ```shell | ||
| cargo clean | ||
| ``` | ||
|
|
||
| Alternatively, you can build in release mode, which should also use less disk | ||
| space: | ||
|
|
||
| ```shell | ||
| cargo build --release | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this should be a pre-requisite... "Make sure you have at least XX GiB of free disk space, or use --release" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default cloud shell only gives you 5GB, if users choose that route it might be helpful to have the cargo clean tip. This happened to one of the friction log testers so it's likely to come up again from non-googlers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I am suggesting that it belongs in the previous section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I moved this section to the "Setting Up Rust on Cloud Shell" section.
|
/gcbrun |
This PR is a clone of #3233. The [Rust Friction Log](https://docs.google.com/document/d/1sQBFLKq1fmc-qJL1tHqsQvRjzsk_bp7xOEpXmNYy72U/edit?resourcekey=0-MMQyQ4t4DVkDzqNA1sp6IQ&tab=t.0#heading=h.kf1buofzahta) gave users a chance to test the onboarding process and give us feedback. This PR addresses the common issues users had. Fixes b/429254171, b/429252054, b/429250702
|
This was merged as #3620. |
The Rust Friction Log gave users a chance to test the onboarding process and give us feedback. This PR addresses the common issues users had.