test: add minimal version testing on non-dev code #3541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3541 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 124 124
Lines 4979 4979
=======================================
Hits 4766 4766
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suzmue
changed the title
coryan
approved these changes
Oct 17, 2025
|
|
||
| impl std::convert::From<KeyAes256> for crate::model::CommonObjectRequestParams { | ||
| fn from(value: KeyAes256) -> Self { | ||
| #[allow(deprecated)] |
There was a problem hiding this comment.
Can you say more words here? What are we using that is deprecated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our minimal version testing currently uses
testwhich brings in dev dependencies. In this case I believe at least async-trait is resolved to different versions: 0.1.13 when using test, 0.1.0 when using check.We also receive a new deprecation warning due to a transitive dependency (related issue RustCrypto/traits#2036).