test(gax-internal): Add tracing tests for http_timeout #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3549 +/- ##
==========================================
+ Coverage 95.70% 95.82% +0.11%
==========================================
Files 125 125
Lines 5029 5029
==========================================
+ Hits 4813 4819 +6
+ Misses 216 210 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westarle
force-pushed
the
test/http-tracing-timeout
branch
2 times, most recently
from
59a52a3 to
5c48460
Compare
coryan
previously approved these changes
Oct 20, 2025
westarle
force-pushed
the
test/http-tracing-timeout
branch
from
5c48460 to
ecfa4f4
Compare
coryan
approved these changes
Oct 21, 2025
| ErrorType::ClientResponseDecodeError => "CLIENT_RESPONSE_DECODE_ERROR".to_string(), | ||
| ErrorType::ClientRedirectError => "CLIENT_REDIRECT_ERROR".to_string(), | ||
| ErrorType::Internal => "INTERNAL".to_string(), | ||
| ErrorType::ClientTimeout => error_type_values::CLIENT_TIMEOUT.to_string(), |
There was a problem hiding this comment.
For a future PR: use error_type_values::* could make this more readable.
| #[test_case(ErrorType::ClientResponseDecodeError, "CLIENT_RESPONSE_DECODE_ERROR", Code::Internal; "Client Response Decode Error")] | ||
| #[test_case(ErrorType::ClientRedirectError, "CLIENT_REDIRECT_ERROR", Code::Aborted; "Client Redirect Error")] | ||
| #[test_case(ErrorType::Internal, "INTERNAL", Code::Internal; "Internal")] | ||
| #[test_case(ErrorType::ClientTimeout, error_type_values::CLIENT_TIMEOUT, Code::DeadlineExceeded; "Client Timeout")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.