Skip to content

test(bigquery): handle 404 err when cleaning stale datasets #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2025
Merged

test(bigquery): handle 404 err when cleaning stale datasets #3594

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87af03a
test(bigquery): handle 404 err when cleaning stale datasets
alvarowolfx Oct 20, 2025
5c24746
refactor: improve stale ds filter based on review comments
alvarowolfx Oct 21, 2025
e36b352
fix: fmt all the things
alvarowolfx Oct 21, 2025
c33dd10
fix: clippy all the things
alvarowolfx Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/integration-tests/src/bigquery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

use crate::Result;
use futures::stream::StreamExt;
use gax::paginator::ItemPaginator;
use gax::{error::rpc::Code, paginator::ItemPaginator};
use rand::{Rng, distr::Alphanumeric};

const INSTANCE_LABEL: &str = "rust-sdk-integration-test";
Expand Down Expand Up @@ -113,8 +113,12 @@ async fn cleanup_stale_datasets(
let stale_datasets = futures::future::join_all(pending_all_datasets)
.await
.into_iter()
.filter_map(|r| {
let dataset = r.unwrap();
.filter_map(|r| match r {
Ok(dataset) => Some(dataset),
Err(e) if e.status().is_some_and(|s| s.code == Code::NotFound) => None,
Err(_) => panic!("expected a successful get_dataset()"),
})
.filter_map(|dataset| {
if dataset
.labels
.get(INSTANCE_LABEL)
Expand Down
Loading