test(pubsub): speed up testing on macOS#5088
Merged
coryan merged 1 commit intogoogleapis:mainfrom Mar 23, 2026
Merged
Conversation
Without this change the test takes over 2 minutes on macOS. At least one attempt takes over 10 minutes. It is possible it is even deadlocked or at least not making progress. With this change the test passes in less than 100ms.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5088 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 215 215
Lines 41403 41403
=======================================
Hits 40437 40437
Misses 966 966 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alvarowolfx
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change the test takes over 2 minutes on macOS. At least one attempt takes over 10 minutes. It is possible it is even deadlocked or at least not making progress.
With this change the test passes in less than 100ms.