Skip to content

docs(sample): add custom retry algo samples #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

docs(sample): add custom retry algo samples #3948

wants to merge 6 commits into from

Conversation

@whuffman36
Copy link
Contributor

No description provided.

@whuffman36 whuffman36 self-assigned this Sep 3, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Sep 3, 2025
@whuffman36 whuffman36 marked this pull request as ready for review September 3, 2025 19:34
@snippet-bot
Copy link

snippet-bot bot commented Sep 3, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@whuffman36
Copy link
Contributor Author

The sample and test will not build since the version of the sdk that the samples refer to has not been updated to include the PR that introduced the custom exception handler. This should be fixed when the samples are updated to refer to the latest version of the sdk.

PhongChuong
PhongChuong reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

samples/snippets/src/main/java/com/example/bigquery/SetCustomRetryAlgorithm.java Outdated
public class SetCustomRetryAlgorithm {
// In order to use a custom retry algorithm, you must implement a custom
// Interceptor that implements the ExceptionHandler.Interceptor interface.
public static final ExceptionHandler.Interceptor EXCEPTION_HANDLER_INTERCEPTOR =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify this by using the publicly available one at:
https://github.com/googleapis/sdk-platform-java/blob/f18318660c05d0d8466e3ead7127f0747fac2e2e/java-core/google-cloud-core/src/main/java/com/google/cloud/BaseService.java#L30

Just mentions that they can optionally implement their own.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't know about this one, thanks! I put in a comment explaining how to implement your own.

@PhongChuong
Copy link
Contributor

Just realized, you might want to change the PR title to:
docs(sample): add custom retry algo samples
So it doesn't bump the semantic version.

@whuffman36 whuffman36 changed the title feat(bigquery): implement custom retry algo samples docs(sample): add custom retry algo samples Sep 4, 2025
@PhongChuong
Copy link
Contributor

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhongChuong PhongChuong PhongChuong approved these changes

Assignees

@whuffman36 whuffman36

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whuffman36 @PhongChuong