chore(x-goog-spanner-request-id): more updates for feature completion: WIP #3915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
odeke-em
force-pushed
the
plumbing2+enforcemenet
branch
from
c6c2c74 to
214ad86
Compare
odeke-em
force-pushed
the
plumbing2+enforcemenet
branch
from
214ad86 to
b8d897d
Compare
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 22, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 22, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 23, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 23, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 26, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
olavloite
pushed a commit
that referenced
this pull request
Jun 27, 2025
…s prior code review suggestions (#3922) * chore(x-goog-spanner-request-id): propagate reqId into exceptions plus prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR #3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR #3898 and PR #3915 * Update tests with session.getRequestIdCreator * More plumbing * Update tests * Deal with the multiplex-session .getOptions null returns in getChannel * Correct array copy
odeke-em
force-pushed
the
plumbing2+enforcemenet
branch
2 times, most recently
from
b1b5b3e to
35882d8
Compare
…tries + aborts Updates googleapis#3537 chore(x-goog-spanner-request-id): add BeginTransaction+ResumableStreamIterator Plumbs x-goog-spanner-request-id into BeginTransaction and ResumableStreamIterator and for PartitionedDmlTransaction. Updates googleapis#3537 Get more tests reveal needs for plumbing Add requestId to PartitionQuery + PartitionRead Propagate requestId into some more SpannerException values Use session.getChannel() and assert for results More debugging + fix up sorting comparator Fix more channelId TODOs Fix up withNthRequest for deterministic checks for BatchCreateSessions More retrofits More updates for tests More validity checks Add debugs to assert behavior of outgoing headers
odeke-em
force-pushed
the
plumbing2+enforcemenet
branch
from
cffb030 to
32ff677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumbs more updates so as to get to feature completion.