feat(dart): implement bump

internal/git/git.go

@@ -185,3 +185,24 @@ func GetCommitSubject(ctx context.Context, gitExe, revision string) (string, err
 	}
 	return strings.TrimSuffix(output, "\n"), nil
 }
+
+// FormatTagName formats a tag name using tagFormat, name and version.
+func FormatTagName(tagFormat, name, version string) string {
+	return strings.NewReplacer("{name}", name, "{version}", version).Replace(tagFormat)
+}
+
+// HasChangesIn checks if any of the filesChanged are inside dir (excluding exclusion if non-empty).
+func HasChangesIn(dir, exclusion string, filesChanged []string) bool {
+	if !strings.HasSuffix(dir, "/") {
+		dir += "/"
+	}
+	for _, f := range filesChanged {
+		if strings.HasPrefix(f, dir) {
+			if exclusion != "" && strings.HasPrefix(f, exclusion) {
+				continue
+			}
+			return true
+		}
+	}
+	return false
+}

internal/git/git_test.go

@@ -599,6 +599,88 @@ func TestGetCommitSubject_Error(t *testing.T) {
 	}
 }
 
+func TestFormatTagName(t *testing.T) {
+	for _, test := range []struct {
+		name      string
+		tagFormat string
+		pkgName   string
+		version   string
+		want      string
+	}{
+		{
+			name:      "standard tag",
+			tagFormat: "{name}/v{version}",
+			pkgName:   "storage",
+			version:   "1.2.3",
+			want:      "storage/v1.2.3",
+		},
+		{
+			name:      "different format",
+			tagFormat: "release-{name}-{version}",
+			pkgName:   "pubsub",
+			version:   "0.4.0",
+			want:      "release-pubsub-0.4.0",
+		},
+	} {
+		t.Run(test.name, func(t *testing.T) {
+			got := FormatTagName(test.tagFormat, test.pkgName, test.version)
+			if got != test.want {
+				t.Errorf("FormatTagName(%q, %q, %q) = %q; want %q", test.tagFormat, test.pkgName, test.version, got, test.want)
+			}
+		})
+	}
+}
+
+func TestHasChangesIn(t *testing.T) {
+	for _, test := range []struct {
+		name         string
+		dir          string
+		exclusion    string
+		filesChanged []string
+		want         bool
+	}{
+		{
+			name:         "match exact prefix with trailing slash",
+			dir:          "packages/my_package/",
+			filesChanged: []string{"packages/my_package/lib/src/foo.dart"},
+			want:         true,
+		},
+		{
+			name:         "match prefix without trailing slash",
+			dir:          "packages/my_package",
+			filesChanged: []string{"packages/my_package/lib/src/foo.dart"},
+			want:         true,
+		},
+		{
+			name:         "no match different package",
+			dir:          "packages/my_package",
+			filesChanged: []string{"packages/other_package/lib/src/foo.dart"},
+			want:         false,
+		},
+		{
+			name:         "exclusion matches",
+			dir:          "packages/my_package",
+			exclusion:    "packages/my_package/ignored",
+			filesChanged: []string{"packages/my_package/ignored/foo.dart"},
+			want:         false,
+		},
+		{
+			name:         "exclusion does not match change",
+			dir:          "packages/my_package",
+			exclusion:    "packages/my_package/ignored",
+			filesChanged: []string{"packages/my_package/lib/src/foo.dart"},
+			want:         true,
+		},
+	} {
+		t.Run(test.name, func(t *testing.T) {
+			got := HasChangesIn(test.dir, test.exclusion, test.filesChanged)
+			if got != test.want {
+				t.Errorf("HasChangesIn(%q, %q, %v) = %v; want %v", test.dir, test.exclusion, test.filesChanged, got, test.want)
+			}
+		})
+	}
+}
+
 func TestGitConfigIgnoreGlobalSigning(t *testing.T) {
 	fakeGlobalConfig := filepath.Join(t.TempDir(), ".gitconfig")
 	gitConfigContent := `

internal/librarian/bump.go

@@ -19,11 +19,11 @@ import (
 	"errors"
 	"fmt"
 	"path/filepath"
-	"strings"
 
 	"github.com/googleapis/librarian/internal/command"
 	"github.com/googleapis/librarian/internal/config"
 	"github.com/googleapis/librarian/internal/git"
+	"github.com/googleapis/librarian/internal/librarian/dart"
 	"github.com/googleapis/librarian/internal/librarian/golang"
 	"github.com/googleapis/librarian/internal/librarian/python"
 	"github.com/googleapis/librarian/internal/librarian/rust"
@@ -122,6 +122,12 @@ func runBump(ctx context.Context, cfg *config.Config, all bool, libraryName, ver
 	if cfg.Language == config.LanguageSwift {
 		return legacySidekickBump(ctx, cfg, all, libraryName, versionOverride)
 	}
+	if cfg.Language == config.LanguageDart {
+		if err := dart.Bump(ctx, cfg, all, libraryName, versionOverride); err != nil {
+			return err
+		}
+		return RunTidyOnConfig(ctx, ".", cfg)
+	}
 
 	librariesToBump, err := findLibrariesToBump(ctx, cfg, all, libraryName)
 	if err != nil {
@@ -162,7 +168,7 @@ func findLibrariesToBump(ctx context.Context, cfg *config.Config, all bool, libr
 		if lib.SkipRelease || lib.Version == "" {
 			continue
 		}
-		lastReleaseTagName := formatTagName(cfg.Default.TagFormat, lib)
+		lastReleaseTagName := git.FormatTagName(cfg.Default.TagFormat, lib.Name, lib.Version)
 		lastReleaseTagCommit, err := git.GetCommitHash(ctx, command.Git, lastReleaseTagName)
 		if err != nil {
 			return nil, fmt.Errorf("error retrieving commit for tag %s (from library %s version %s): %w", lastReleaseTagName, lib.Name, lib.Version, err)
@@ -193,22 +199,7 @@ func libraryChanged(cfg *config.Config, library *config.Library, filesChanged []
 	default:
 		output = libraryOutput(cfg.Language, library, cfg.Default)
 	}
-	return hasChangesIn(output, exclusion, filesChanged)
-}
-
-func hasChangesIn(dir, exclusion string, filesChanged []string) bool {
-	if !strings.HasSuffix(dir, "/") {
-		dir += "/"
-	}
-	for _, f := range filesChanged {
-		if strings.HasPrefix(f, dir) {
-			if exclusion != "" && strings.HasPrefix(f, exclusion) {
-				continue
-			}
-			return true
-		}
-	}
-	return false
+	return git.HasChangesIn(output, exclusion, filesChanged)
 }
 
 // bumpLibrary determines the next version of a library (using versionOverride
@@ -398,7 +389,7 @@ func legacySidekickBumpAll(ctx context.Context, cfg *config.Config, lastTag stri
 			continue
 		}
 		output := libraryOutput(cfg.Language, lib, cfg.Default)
-		if !hasChangesIn(output, "", filesChanged) {
+		if !git.HasChangesIn(output, "", filesChanged) {
 			continue
 		}
 		if err := legacySidekickBumpLibrary(ctx, cfg, lib, lastTag, ""); err != nil {
@@ -432,9 +423,3 @@ func legacySidekickBumpLibrary(ctx context.Context, cfg *config.Config, lib *con
 		return fmt.Errorf("%q should not be using legacySidekickBumpLibrary", cfg.Language)
 	}
 }
-
-// formatTagName computes the name of the tag expected to be applied to the
-// commit that released the given library.
-func formatTagName(tagFormat string, lib *config.Library) string {
-	return strings.NewReplacer("{name}", lib.Name, "{version}", lib.Version).Replace(tagFormat)
-}

internal/librarian/bump_test.go

@@ -496,7 +496,7 @@ func TestFindLibrariesToBump(t *testing.T) {
 				// commit the config, tag it.
 				cfg.Libraries[1].Version = sample.NextVersion
 				writeConfigAndCommit(t, cfg)
-				tagName := formatTagName(cfg.Default.TagFormat, cfg.Libraries[1])
+				tagName := git.FormatTagName(cfg.Default.TagFormat, cfg.Libraries[1].Name, cfg.Libraries[1].Version)
 				git.Tag(t.Context(), "git", tagName, "HEAD")
 			},
 		},