Skip to content

chore(tool/cmd/migrate): parse unversioned build for ruby migration - #7052

Merged
JoeWang1127 merged 27 commits into
googleapis:mainfrom
JoeWang1127:chore/unversioned-build
Jul 27, 2026
Merged

chore(tool/cmd/migrate): parse unversioned build for ruby migration#7052
JoeWang1127 merged 27 commits into
googleapis:mainfrom
JoeWang1127:chore/unversioned-build

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Unversioned build files are now parsed during Ruby client library migration to extract API path overrides and cloud option parameters for wrapper libraries.

For #6632

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for unversioned Ruby wrapper libraries and introduces the ruby-cloud-wrapper-gem-override configuration option. It refactors the migration tool to parse unversioned wrapper builds from BUILD.bazel files and updates the OwlBot config parsing logic. Feedback on the changes points out a potential runtime panic in parseAPIFromWrapperBuild due to unsafe slice indexing and string splitting, suggesting a safer implementation with length checks.

Comment thread tool/cmd/migrate/ruby.go Outdated
@JoeWang1127 JoeWang1127 changed the title chore: parse unversioned build chore(tool/cmd/migrate): parse unversioned build for ruby migration Jul 25, 2026
@JoeWang1127
JoeWang1127 marked this pull request as ready for review July 25, 2026 21:33
@JoeWang1127
JoeWang1127 requested a review from a team as a code owner July 25, 2026 21:33
@JoeWang1127
JoeWang1127 requested a review from suztomo July 25, 2026 21:33
@JoeWang1127
JoeWang1127 merged commit 62b8670 into googleapis:main Jul 27, 2026
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants