feat: Add support for Interval #2192
Conversation
product-auto-label
bot
added
size: l
sagarwaal
force-pushed
the
interval_support
branch
from
e17c3ab to
1b3c462
Compare
sagarwaal
force-pushed
the
interval_support
branch
from
1b3c462 to
8380a9c
Compare
product-auto-label
bot
added
size: xl
sagarwaal
force-pushed
the
interval_support
branch
from
45b2da1 to
8f99313
Compare
olavloite
changed the title
| private days: number; | ||
| private nanoseconds: bigint; | ||
|
|
||
| private static readonly ISO8601_PATTERN: RegExp = |
There was a problem hiding this comment.
@google-cloud/precise-date library has built-in support for ISO 8601 , Can we use that ?
| }); | ||
| }; | ||
|
|
||
| it('GOOGLE_STANDARD_SQL should bind the value when param type interval is used', done => { |
There was a problem hiding this comment.
Please add a test for `GOOGLE_STANDARD_SQL should interval value is passed as string for both typed and untyped params.
var value = (new Interval(19, 768, BigInt('123456789123'))).toISO8601()
| @@ -367,6 +368,7 @@ describe('Spanner', () => { | |||
| googleSqlTable = DATABASE.table(TABLE_NAME); | |||
| postgreSqlTable = PG_DATABASE.table(TABLE_NAME); | |||
| if (IS_EMULATOR_ENABLED) { | |||
| // TODO: add columns using Interval Value and Interval Array Value. | |||
| @@ -6523,6 +6530,264 @@ describe('Spanner', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('interval', () => { | |||
There was a problem hiding this comment.
Test cases for insert are missing. These test cases are only for query. Please add a block in describe('types')
| }); | ||
| }); | ||
|
|
||
| it('should throw error for invalid ISO8601 strings', () => { |
There was a problem hiding this comment.
Please also add test for null, undefined here and elsewhere
| return this.nanoseconds; | ||
| } | ||
|
|
||
| static fromMonths(months: number): Interval { |
There was a problem hiding this comment.
Please add documentation for all public methods.
| private nanoseconds: bigint; | ||
|
|
||
| private static readonly ISO8601_PATTERN: RegExp = | ||
| /^P(?!$)(-?\d+Y)?(-?\d+M)?(-?\d+D)?(T(?=-?[.,]?\d)(-?\d+H)?(-?\d+M)?(-?(((\d+)([.,]\d{1,9})?)|([.,]\d{1,9}))S)?)?$/; |
There was a problem hiding this comment.
Add code comments to explain the regex. Also elsewhere where its not self explanatory.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕