Use stdlib override when possible #561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: m
Replace the abandoned 'overrides' package with stdlib typing.override for Python 3.12+. This fixes AttributeError that occurs in Python 3.14 when importing from overrides. The overrides dependency is now only installed for Python < 3.12 via environment marker.
edrogers
force-pushed
the
use-stdlib-override-when-possible
branch
from
8570abf to
0e94541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560
This PR uses
typing.overridein favor of theoverridesdependency when possible. As of Python 3.12, the standard library offerstyping.overrideto perform a static check on overridden methods.Motivation
Currently,
overridesis incompatible with Python 3.14. As a result, any package that attempts to importoverridesusing Python 3.14+ will raise anAttributeError. An issue has been raised and a pull request has been submitted to the GitHub repo for theoverridesproject. But the maintainer has been unresponsive.To ensure readiness for Python 3.14, this package (and any other package directly depending on
overrides) should consider usingtyping.overrideinstead