feat: add SQL statement for begin transaction isolation level #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
Adds an additional option to the `begin [transaction]` SQL statement to
specify the isolation level of that transaction. The following format is
now supported:
```
{begin | start} [transaction] [isolation level {repeatable read | serializable}]
```
olavloite
force-pushed
the
dbapi-begin-isolation-level
branch
from
f15b60a to
56fe1a5
Compare
aakashanandg
approved these changes
Apr 7, 2025
aakashanandg
reviewed
Apr 7, 2025
| @@ -117,3 +117,27 @@ def test_transaction_isolation_level(self): | |||
| self.assertEqual(1, len(begin_requests)) | |||
| self.assertEqual(begin_requests[0].options.isolation_level, level) | |||
| MockServerTestBase.spanner_service.clear_requests() | |||
|
|
|||
There was a problem hiding this comment.
nit: Should we also include a negative test case for invalid isolation level types? Just to verify the user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional option to the
begin [transaction]SQL statement to specify the isolation level of that transaction. The following format is now supported: