Skip to content

Comments

chore(python): remove MANIFEST.in from templates#2082

Merged
parthea merged 2 commits intomasterfrom
remove-manifest
Apr 14, 2025
Merged

chore(python): remove MANIFEST.in from templates#2082
parthea merged 2 commits intomasterfrom
remove-manifest

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Apr 9, 2025

Remove MANIFEST.in in synthtool templates. This won't delete existing MANIFEST.in files downstream. The downstream files must not be removed. This PR only removes the file from templates so that downstream files are maintained as handwritten ones.

@parthea parthea requested review from a team and chingor13 as code owners April 9, 2025 21:50
@parthea parthea changed the title chore(python): remove MANIFEST.in from synthtool templates chore(python): remove MANIFEST.in from templates Apr 10, 2025
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 10, 2025
@parthea
Copy link
Contributor Author

parthea commented Apr 10, 2025

Wait for googleapis/gapic-generator-python#2367 to be released

@parthea parthea assigned parthea and unassigned chingor13 Apr 11, 2025
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 14, 2025
@parthea parthea merged commit 945610f into master Apr 14, 2025
11 checks passed
@parthea parthea deleted the remove-manifest branch April 14, 2025 10:10
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Apr 14, 2025
Update to the newest version of the post processor which includes the
changes from the following PRs
googleapis/synthtool#2085
googleapis/synthtool#2083
googleapis/synthtool#2082
googleapis/synthtool#2081
googleapis/synthtool#2080
googleapis/synthtool#2079
googleapis/synthtool#2078
googleapis/synthtool#2077
googleapis/synthtool#2076


Run the following commands to obtain the latest sha256
```
docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest
```

```
docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest
[gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:9786b1c0a79c49022430a8d1380a514c3cf24ecf0d261dc4ccf15241edb2dbf3]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants