Add SomeTableProvider trait for traversal and use it in otexplorer#1553
Open
valadaptive wants to merge 1 commit intogooglefonts:mainfrom
Open
Add SomeTableProvider trait for traversal and use it in otexplorer#1553valadaptive wants to merge 1 commit intogooglefonts:mainfrom
SomeTableProvider trait for traversal and use it in otexplorer#1553valadaptive wants to merge 1 commit intogooglefonts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_some_tablefunction was getting a bit out-of-date (it was last updated 3 years ago). I feel like it's tied more toread-fontsthanotexplorer, since it needs to know all of the tables that theTableProvidertrait is capable of returning. As such, I've created aSomeTableProvidertrait inread-fonts, which has one method that does whatget_some_tableused to do.I read through the issues a bit and it seems like the traversal API might get removed at some point, but some people find
otexplorervery useful for debugging. I concur; I've found myself using it a lot to look inside fonts.