Open
Conversation
0184b92 to
0d2cdd6
Compare
Contributor
|
Thanks. I see the following speedup in HB's |
Member
|
There's also #1588 which might complement this and avoid generating a significant amount of unsafe code. |
Member
Author
|
Yea, we are going to ultimately need to decide if we're okay with the unsafe or not. If we are then this approach is probably preferable since it will save the overhead of both storing the extra pointer as well as doing the various bits of validation required to do a bytemuck cast of the struct? But if we decide we aren't okay with the unsafe than an approach like #1588 makes more sense. |
And use it in codegen. This is intended as a proof of concept to explore performance options for harfrust.
0d2cdd6 to
4d5431f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And use it in codegen. This is intended as a proof of concept to explore performance options for harfrust.
This is similar to the first couple commits of #1709 except this is more narrowly scoped (only focused on the two hot-path methods) and is in theory intended to be mergeable if we decide to go this route.