Skip to content

[fauntlet] add type1 support#1762

Open
dfrg wants to merge 2 commits intot1-evalcsfrom
t1-fauntlet
Open

[fauntlet] add type1 support#1762
dfrg wants to merge 2 commits intot1-evalcsfrom
t1-fauntlet

Conversation

@dfrg
Copy link
Member

@dfrg dfrg commented Mar 13, 2026

Adds support for detecting and processing type1 fonts to fauntlet. Also adds a check for a few tests fonts to CI.

Additionally makes the type1 support in read-fonts visible and fixes a few warnings that were missed due to the expect(unused) attribute.

First commit contains an intentionally broken type1 scale factor in fauntlet to prove that the CI checks are working.

Based on #1761 which must land first.

dfrg added 2 commits March 13, 2026 16:40
Adds support for detecting and processing type1 fonts to fauntlet. Also adds a check for a few tests fonts to CI.

Additionally makes the type1 support in read-fonts visible and fixes a few warnings that were missed due to the expect(unused) attribute.

First commit contains an intentionally broken type1 scale factor in fauntlet to prove that the CI checks are working.

Based on #1761 which must land first.
@dfrg
Copy link
Member Author

dfrg commented Mar 13, 2026

Failing fauntlet check: https://github.com/googlefonts/fontations/actions/runs/23069665578/job/67016691012?pr=1762

Run cargo run --release -p fauntlet -- compare-glyphs --print-paths --exit-on-fail font-test-data/test_data/type1/*.pf*
    Finished `release` profile [optimized] target(s) in 0.06s
     Running `target/release/fauntlet compare-glyphs --print-paths --exit-on-fail font-test-data/test_data/type1/notoserif-regular.subset.pfa font-test-data/test_data/type1/notoserif-regular.subset.pfb`
["font-test-data/test_data/type1/notoserif-regular.subset.pfa"]
["font-test-data/test_data/type1/notoserif-regular.subset.pfb"]
["font-test-data/test_data/type1/notoserif-regular.subset.pfa"#0 ppem: 8 coords: [] hinting None] glyph id 1 outline doesn't match:
- MoveTo { x: 0.296875, y: 0.0 }
- LineTo { x: 2.625, y: 0.0 }
- LineTo { x: 2.625, y: 0.34375 }
- LineTo { x: 2.53125, y: 0.34375 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant