[crater] Cache output of fontmake between runs #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
crater-prebuild-binaries
branch
from
3ba18c7
to
63fccd9
Compare
rsheeter
reviewed
Oct 30, 2024
rsheeter
approved these changes
Oct 30, 2024
This clears the cache if the pip freeze output is different. It's possible that this isn't worth the complexity, but it should offer meaningful runtime speed improvements, so let's give it a try?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clears the cache if the pip freeze output is different.
It's possible that this isn't worth the complexity, but it should offer meaningful runtime speed improvements, so let's give it a try?