[ttx_diff] Only report size issues if fontc > fontmake #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Nov 12, 2024
resources/scripts/ttx_diff.py
Outdated
| @@ -513,6 +513,8 @@ def check_sizes(fontmake_ttf: Path, fontc_ttf: Path): | |||
| for key in shared_keys: | |||
| fontmake_len = fontmake[key] | |||
| fontc_len = fontc[key] | |||
| if fontc_len <= fontmake_len: | |||
| continue | |||
| len_ratio = min(fontc_len, fontmake_len) / max(fontc_len, fontmake_len) | |||
There was a problem hiding this comment.
Alternately just say if fontc_len / fontmake_len > THRESHOLD?
rsheeter
approved these changes
Nov 12, 2024
If we're smaller and the ttx is equivalent, that seems fine.
cmyr
force-pushed
the
allow-smaller-us
branch
from
1ff0b9b
to
ffcfadf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're smaller and the ttx is equivalent, that seems fine.