Skip to content

fix(gmail): parse message headers case-insensitively#798

Open
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/gmail-header-case-insensitive
Open

fix(gmail): parse message headers case-insensitively#798
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/gmail-header-case-insensitive

Conversation

@Lubrsy706
Copy link
Copy Markdown

Fixes #642.

Summary

  • parse Gmail message headers with case-insensitive names
  • cover mixed/lower/upper-case From, Reply-To, To, Cc, Subject, Date, Message-ID, and References headers

Tests

  • cargo fmt --check
  • cargo test -p google-workspace-cli test_parse_original_message_headers_are_case_insensitive

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

⚠️ No Changeset found

Latest commit: 3f3c0b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label May 14, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the Gmail message header parsing logic. By normalizing header names to lowercase before processing, the system now correctly handles variations in header casing, preventing potential data loss or parsing errors when dealing with non-standard email inputs.

Highlights

  • Case-Insensitive Header Parsing: Updated the Gmail message header parsing logic to normalize header names to lowercase, ensuring consistent handling regardless of the original casing.
  • Regression Testing: Added a new test case to verify that various email headers are correctly parsed even when provided with mixed or non-standard casing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gmail message header parsing to be case-insensitive by converting header names to lowercase before matching. It also includes a new test case to verify that headers with different casing are correctly handled. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(gmail): parse_message_headers uses case-sensitive match, drops CC/headers with non-canonical casing

2 participants