fix(gmail): send html bodies as multipart alternative#799
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves email compatibility by ensuring that HTML-formatted emails sent via the Gmail integration include a text/plain alternative. This change helps email clients that do not support HTML or prefer plain text to render the message correctly, while maintaining proper support for inline CID images and existing attachment handling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to automatically generate a plain text version of HTML email bodies using a new html_to_plain_text helper function. It updates the finalize_message function to include both text/plain and text/html parts within a multipart/alternative structure when sending HTML emails, ensuring better compatibility with email clients. Corresponding tests were added and updated to verify the correct generation of these multipart messages. I have no feedback to provide.
Fixes #793.
Summary
gmail +send --htmlTests
cargo fmt --checkcargo test -p google-workspace-cli finalize_messagecargo test -p google-workspace-cli test_attachment_with_html_body