fix(auth): avoid forcing userinfo profile scope

[Lubrsy706]

Fixes #770.

Summary

• keep only openid and userinfo.email as login identity scopes
• stop auto-requesting userinfo.profile during auth login so OAuth clients that cannot request it can still complete login
• add a regression test that profile is not reintroduced as a forced login scope

Tests

• cargo fmt --check
• cargo test -p google-workspace-cli ensure_login_identity_scopes_does_not_force_profile_scope

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0eb407d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the authentication flow to prevent the automatic request of the 'userinfo.profile' scope. By restricting mandatory identity scopes to 'openid' and 'userinfo.email', the application becomes more flexible for OAuth clients that lack permission to request profile information, while maintaining necessary user identification capabilities.

Highlights

• Scope Modification: Removed the forced inclusion of the 'userinfo.profile' scope during the authentication login process to improve compatibility with restricted OAuth clients.
• Code Refactoring: Introduced a dedicated 'ensure_login_identity_scopes' helper function to manage mandatory identity scopes, keeping only 'openid' and 'userinfo.email'.
• Regression Testing: Added a new unit test to verify that the 'userinfo.profile' scope is not automatically added to the requested scopes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the scope handling logic in auth_commands.rs by introducing the ensure_login_identity_scopes helper function. The change removes the mandatory inclusion of the userinfo.profile scope to accommodate OAuth clients that cannot request it, while ensuring openid and userinfo.email remain present. A new unit test verifies that the profile scope is no longer forced. I have no feedback to provide.