Skip to content

fix(auth): include contacts scope for people#810

Open
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/people-contacts-scope
Open

fix(auth): include contacts scope for people#810
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/people-contacts-scope

Conversation

@Lubrsy706
Copy link
Copy Markdown

Summary

  • Add the People/Contacts write scope to --full auth logins
  • Include contacts in the static scope picker so -s people has a write-capable scope even without Discovery-backed scope selection
  • Add regression coverage for People service filtering with --full

Fixes #673

Tests

  • cargo fmt --check
  • cargo test -p google-workspace-cli contacts_write -- --nocapture
  • cargo check -p google-workspace-cli
  • git diff --check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 15, 2026

⚠️ No Changeset found

Latest commit: 59ff9fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the authentication configuration for the Google Workspace CLI to include the contacts write scope. By integrating this scope into both the default full-access list and the static scope picker, it ensures that users can properly authorize contact-related operations without relying on dynamic discovery mechanisms. The changes also include updated test coverage to prevent regressions in service-based scope filtering.

Highlights

  • Scope Expansion: Added the Google Contacts write scope to the full authentication scope list.
  • UI/UX Improvement: Included Google Contacts in the static scope picker to ensure availability when Discovery-backed selection is not used.
  • Testing: Added regression tests to verify that the People service correctly includes the contacts scope under full authentication mode.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the Google Contacts OAuth scope to the FULL_SCOPES list and the SCOPE_ENTRIES constant in auth_commands.rs. It also includes unit tests to ensure the contacts scope is correctly included in full scope resolution and when the people service is specified. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auth login -s people does not include contacts write scope

2 participants