fix(auth): include contacts scope for people#810
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the authentication configuration for the Google Workspace CLI to include the contacts write scope. By integrating this scope into both the default full-access list and the static scope picker, it ensures that users can properly authorize contact-related operations without relying on dynamic discovery mechanisms. The changes also include updated test coverage to prevent regressions in service-based scope filtering. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the Google Contacts OAuth scope to the FULL_SCOPES list and the SCOPE_ENTRIES constant in auth_commands.rs. It also includes unit tests to ensure the contacts scope is correctly included in full scope resolution and when the people service is specified. I have no feedback to provide.
Summary
--fullauth loginscontactsin the static scope picker so-s peoplehas a write-capable scope even without Discovery-backed scope selection--fullFixes #673
Tests