Conversation
vvakame
reviewed
Sep 10, 2018
vvakame
left a comment
vvakame
left a comment
There was a problem hiding this comment.
テストが書けるとよいですね。
全体的に関数のみで構成されているので、美しいコードとするためにどこかでstruct+methodを使うとよりよくできないか考えてみるとよいでしょう。
他の人に僕が書いたレビューも読んで貰えると嬉しいです(同じような内容は指摘漏れしてたりするので…
| } | ||
| } | ||
|
|
||
| func acceptsRangeRequest(url string) (int, bool) { |
There was a problem hiding this comment.
このパターンの場合、errorを返したほうがよいと思います。
例えばURLがinvalidだった場合など。
握りつぶしているerrのうち、握りつぶすのが妥当なものは無さそうです。
| } | ||
| defer resp.Body.Close() | ||
| unit := resp.Header.Get("Accept-Ranges") | ||
| length, err := strconv.Atoi(resp.Header.Get("Content-Length")) |
|
|
||
| func concat(dst io.Writer, srcs []io.Reader) error { | ||
| for _, src := range srcs { | ||
| err := func() error { |
| length, ok := acceptsRangeRequest(url) | ||
| if num > 1 && ok { | ||
| b := length/num + 1 | ||
| eg, ctx := errgroup.WithContext(context.Background()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
詳細はREADME.mdに記載