This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Remove bluebird promises - #40
Open
bsouthga wants to merge 3 commits into
Open
Conversation
|
+1 I encountered the same issue and this PR saved me. |
|
Did this change work well, without any performance deprecation? |
Author
|
Yeah, it worked great (we eventually switched to the native mongodb driver itself, but this ran in production for a while) |
|
Thanks. I started having issues once I upgraded bluebird in the rest of my app to bluebird 3 and found issues in production. Just saw that native mognodb driver now supports promises, which is useful as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #39 which seems to stem from the usage of bluebird promises. Bluebird is removed as a dependency (and corejs/BabelJS promises are used instead) and a performance test is added.