-
-
Notifications
You must be signed in to change notification settings - Fork 916
fix: fixed function undefined error in useBoundingClientRect #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: fixed function undefined error in useBoundingClientRect #2561
Conversation
|
Good, I tried the Fix in this PR and it resolves the conflict. |
|
Also tried this fix and it resolved the issue |
Thanks, it is worked |
|
This fix resolves the issue. Thanks! |
|
@gorhom Can you please have a look as this one is easy to reproduce with react-native 0.82. It has been brought up in multiple places now: Issues:
PRs:
I think this asks for a release / update 🙏 |
|
For now you can download and paste this file inside "patches" folder |
Temporary FixIf you're using npm or yarn, you can follow these steps to apply this patch until @gorhom releases a new update: Step 1: Install patch-packageInstall npm install patch-package --save-dev
# or
yarn add patch-package --devStep 2: Add postinstall scriptAdd the following script to your {
"scripts": {
"postinstall": "patch-package"
}
}Step 3: Download and apply the patch
npm install
# or
yarn installNoteThe patch should now be automatically applied whenever you install dependencies. make sure to commit the |
Motivation
For some weird reason, this bug happens to bottom sheet when I load it on RN 0.82.1
This PR fixes the issue as detailed in this link