Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StrictQueryParamSep router option (#781) #782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jub0bs
Copy link

@jub0bs jub0bs commented Mar 17, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Add a router option for disabling semicolons as separators for query-parameter pairs (in accordance with the URL Living Standard). Issue #781 discusses two other viable options; please let me know if you prefer one of them and I'll modify this PR accordingly.

Related Tickets & Documents

#781

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Personally I wouldn't mind having it on as default, but I trust your judgement in keeping it off for now.

@jub0bs
Copy link
Author

jub0bs commented Mar 18, 2025

@klauspost Thanks! It would be interesting to hear from other gorilla/mux dependents as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants