Mask environment variable values in logs#267
Conversation
Implement `cmd.Mask` to replace the values of leading environment variable assignments with `[MASKED]`. Use this function in the `build` pipeline's `runExec` helper to prevent secret leakage in build logs. Added unit tests for `cmd.Mask` and a regression test in the `build` package to ensure secrets are correctly masked.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Implemented a security enhancement that masks sensitive environment variable values when logging command lines.
Key changes:
cmd.Mask(cmdLine string) stringutility that usesshellwordsto parse and sanitize inline environment variables.runExecinbuild/helper.goto usecmd.Maskfor its logging output.cmd/security_test.goandbuild/security_test.goto verify the masking logic and its integration.nolint:mnddirective tocmd/cmd.goto comply with project linting rules.PR created automatically by Jules for task 4955053604779549119 started by @pellared