Mask inline environment variables in command logs#280
Conversation
This change introduces a `cmd.Mask` function that identifies leading environment variable assignments in a command line string and replaces their values with `[MASKED]`. This function is now used by `runExec` in the build system to ensure that inline secrets are not exposed in build logs. - Added `cmd.Mask` in `cmd/cmd.go`. - Added unit tests for `cmd.Mask` in `cmd/security_test.go`. - Updated `runExec` in `build/helper.go` to use `cmd.Mask`. - Added a regression test in `build/security_test.go`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Introduced a
cmd.Maskfunction to sanitize command-line logs by masking inline environment variable values. Integrated this into therunExecbuild helper and added comprehensive tests to ensure secrets are not leaked while maintaining log readability.PR created automatically by Jules for task 11739211696522631373 started by @pellared