Add PTX Debug #88
Add PTX Debug #88
Conversation
There was a problem hiding this comment.
Overall I think this looks okay.
However, the code to emit the debug PTX is always run (even if we are not debugging anything) - I think this will only happen when the code is loaded so the perf hit is minimal, but interleaving all the debugging code with the normal execution code makes it really hard to read/modify. Can we try to pull all the code creating the debug code into separate function instead of sprinkling it all over the normal flow?
| if( num_elem >= 6 ) out[5] = o.reg6_num(); | ||
| if( num_elem >= 7 ) out[6] = o.reg7_num(); | ||
| if( num_elem >= 8 ) out[7] = o.reg8_num(); | ||
| if( num_elem >= 1 ) |
There was a problem hiding this comment.
Clearly this works - but can we separate all the debug code creation from the normal code flow?
All this code is actually called even if we not doing the debug part...
Can we pull the creation of the debug ptx into a separate function, only called when debugging is enabled?
add relevant store after each instruction in ptx code