-
Notifications
You must be signed in to change notification settings - Fork 100
Generate a case-count report on pull requests #4548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2956fd8 to
2672526
Compare
And update the parameterization docs and checklist. This also makes it easy for us to add additional stuff to the bot comment if we want to later. (Like we used to have previews but disabled them in gpuweb#3131.)
2672526 to
aa567c3
Compare
|
Test failure is expected because it tries to run the previous version of |
|
Sigh, not working because the test PR is from a fork (https://github.com/orgs/community/discussions/25220). Will leave it on while I try to figure it out, it doesn't block PRs. |
|
Took a few revisions: 4ed1a40...8f6f731 |
And update the parameterization docs and checklist.
This adds about 2 minutes to the CI run (one minute each to generate the report before and after the PR).
This also makes it easy for us to add additional text to the bot comment if we want to later. (We might do that if we re-enable previews, which were disabled in #3131.)
Here's a sample comment from kainino0x#1
Issue: None
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.