Skip to content

Conversation

@kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Jan 3, 2026

And update the parameterization docs and checklist.

This adds about 2 minutes to the CI run (one minute each to generate the report before and after the PR).

This also makes it easy for us to add additional text to the bot comment if we want to later. (We might do that if we re-enable previews, which were disabled in #3131.)

Here's a sample comment from kainino0x#1

Results for build job (at 28ceb80):

-webgpu:examples:basic,builder_cases_subcases:* - 2 cases, 4 subcases (~2/case)
+webgpu:examples:basic,builder_cases_subcases:* - 3 cases, 9 subcases (~3/case)
-TOTAL: 284493 cases, 2341915 subcases
+TOTAL: 284494 cases, 2341920 subcases

Issue: None


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [n/a] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [n/a] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located in the test tree.
  • [n/a] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • [n/a] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x force-pushed the case-count-report branch 5 times, most recently from 2956fd8 to 2672526 Compare January 3, 2026 06:43
And update the parameterization docs and checklist.

This also makes it easy for us to add additional stuff to the bot
comment if we want to later. (Like we used to have previews but disabled
them in gpuweb#3131.)
@kainino0x kainino0x marked this pull request as ready for review January 3, 2026 06:49
@kainino0x kainino0x requested a review from greggman January 3, 2026 06:50
@kainino0x
Copy link
Collaborator Author

Test failure is expected because it tries to run the previous version of tools/validate with the new flag. Little janky but I think it'll be fine, I'll force merge.

@kainino0x kainino0x merged commit 4ed1a40 into gpuweb:main Jan 5, 2026
1 check failed
@kainino0x kainino0x deleted the case-count-report branch January 5, 2026 21:36
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
@kainino0x
Copy link
Collaborator Author

Sigh, not working because the test PR is from a fork (https://github.com/orgs/community/discussions/25220). Will leave it on while I try to figure it out, it doesn't block PRs.

kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 5, 2026
@kainino0x
Copy link
Collaborator Author

kainino0x commented Jan 5, 2026

Took a few revisions: 4ed1a40...8f6f731
but seems to work now: #4549

kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 6, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 6, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 6, 2026
kainino0x added a commit to kainino0x/cts that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants