Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Beyla setting Service Name/Namespace/Instance according to OTEL collector #1415

Merged
merged 8 commits into from
Nov 29, 2024
Prev Previous commit
Next Next commit
fix misleading comment
mariomac committed Nov 27, 2024
commit 152d49db75c9172ec42eb0db2b530558ac5bfca8
6 changes: 2 additions & 4 deletions pkg/internal/kube/store.go
Original file line number Diff line number Diff line change
@@ -51,12 +51,10 @@ var DefaultMetadataSources = MetadataSources{
ServiceNamespaceAnnotations: []string{
"resource.opentelemetry.io/service.namespace",
},
// default by empty. If the OTEL operator Instrumentation CRD sets useLabelsForResourceAttributes: true,
// empty by default. If a user sets useLabelsForResourceAttributes: true it its OTEL operator, also
// the values below should be populated so:
// - `app.kubernetes.io/name` becomes `service.name`
// - `app.kubernetes.io/version` becomes `service.version`
// - `app.kubernetes.io/part-of` becomes `service.namespace`
// - `app.kubernetes.io/instance` becomes `service.instance.id`
// - `app.kubernetes.io/part-of` becomes `service.namespace`
ServiceNameLabels: nil,
ServiceNamespaceLabels: nil,
}