-
Notifications
You must be signed in to change notification settings - Fork 100
chore: rename UserActionSeverity to UserActionImportance #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…o fix zizmor cache-poisoning errors
😢 zizmor failed with exit code 14. Expand for full output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eskirk can we change a UserActionImportance
enum to a constant.
E. g. like const userActionImportance: 'critical' | 'normal'?
This makes it much easier to use then forcing users to always use the enum.
Atm you cant't do something like the below without getting linter errors because you can't compare string value with enum.
startUserAction('foo', undefined, { severity: 'critical' });
"importance" fits our internal representation of user actions better than "severity" - so I am deprecating the "severity" parameter in favor of "importance".