Skip to content

Sleep isn't needed at end of arrival rate iter #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

MattDodsonEnglish
Copy link
Contributor

@MattDodsonEnglish MattDodsonEnglish commented Jan 27, 2023

From discussion in #900

@@ -40,7 +39,15 @@ this executor has the following options:
## When to use

When you want to maintain a constant number of iterations without being affected by the
performance of the system under test.
performance of the system under test. To reliably achieve a fixed request rate, try to keep test function simple, with preferably only a single request call,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that recommending to only have 1 request is a good thing. While this will simplify calculating how many VUs you need in normal cases it :

  1. in practice makes it seem like the executor can't handle anything more complicated, which is far from the truth
  2. again in the case that the SUT is failing the "request should take no more than 1s" thinking is still not going to fix anything when it is taking 1m ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just moved that from the old section; it struck me as pretty much invalidating all complex uses of arrival rate. Will delete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1008/merge

It will be deleted automatically in 30 days.

@MattDodsonEnglish
Copy link
Contributor Author

One other thing to note, I wrote "It's unneeded" whereas @sniku wrote "It's a bad idea". We can make the wording a little stronger if the reason it is a bad idea is something more than "It's unnecessary." But if we do that, we should also explain a bit more.

…s/01 Executors/05 constant-arrival-rate.md

Co-authored-by: Mihail Stoykov <[email protected]>
@MattDodsonEnglish MattDodsonEnglish merged commit ae64d0f into main Jan 31, 2023
@MattDodsonEnglish MattDodsonEnglish deleted the 900-sleep-arrival-rates branch January 31, 2023 09:02
MattDodsonEnglish added a commit that referenced this pull request May 8, 2023
I forgot to remove the comments in #1008, causing incoherence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants