Skip to content

Conversation

heitortsergent
Copy link
Collaborator

@heitortsergent heitortsergent commented Apr 8, 2025

What?

Updates to the "Using k6 browser" section.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

@heitortsergent heitortsergent self-assigned this Apr 8, 2025
@heitortsergent heitortsergent added the Area: browser The browser module label Apr 8, 2025
@heitortsergent heitortsergent requested a review from oleiade April 8, 2025 22:10
Copy link
Contributor

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a tiny clarification question, but it's good to merge-as-is 👏🏻

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2025

CLA assistant check
All committers have signed the CLA.

Add changes based on Ankur's feedback, update page to mention most browser methods return promises. Add example of using waitFor
Add content to Write your first browser test based on the Write your first test page, and the k6 new browser template script
@heitortsergent heitortsergent marked this pull request as ready for review July 15, 2025 21:24
@heitortsergent heitortsergent requested review from a team and ankur22 and removed request for a team July 15, 2025 21:24
@heitortsergent
Copy link
Collaborator Author

@ankur22 @oleiade I also added content to the "Write your first browser test" page, if you could take a quick look and let me know what you think. 🙇

@heitortsergent heitortsergent merged commit 93ca95c into main Jul 17, 2025
7 checks passed
@heitortsergent heitortsergent deleted the k6-browser-updates branch July 17, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants