Add k6 binary provisioning preview#1937
Conversation
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
requested review from
Lantero,
codebien,
dgzlopes,
inancgumus and
mstoykov
and removed request for
a team,
inancgumus and
mstoykov
There was a problem hiding this comment.
The technical content looks good to me. I assume @heitortsergent will handle grammar and formatting.
|
@heitortsergent, the code execution is failing. I tried to skip but it is still being executed. Can you please help me with this? 🙏 |
|
Content-wise, the PR LGTM. That said, given that the current state is the following:
Shouldn't this live in the Cloud docs? We could still have a reference in the extension sections... but yeah |
I believe it should and it might make sense to document it from the perspective of being able to use k6 extensions in Grafana Cloud. The CLI support of Binary Provisioning is there to match the Cloud experience. |
andrewslotin
left a comment
andrewslotin
left a comment
There was a problem hiding this comment.
Rephrased for readability.
heitortsergent
left a comment
heitortsergent
left a comment
There was a problem hiding this comment.
Made some small suggestions, but I'd like to change the structure a little bit so it follows our style guide. Do you mind if I make some changes directly to the branch @pablochacin?
We could also merge this after resolving the open comments, and I can made edits later if that's ok. 🤓
| ```windows-powershell | ||
|
|
||
| ``` | ||
|
|
||
| ```windows | ||
| ``` |
There was a problem hiding this comment.
| ```windows-powershell | |
| ``` | |
| ```windows | |
| ``` |
Can we remove these since there are no specific commands for it?
There was a problem hiding this comment.
@heitortsergent I think there should be, because this is available for Windows users, only that I don't have a windows machine to test them
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com> Co-authored-by: Andrey Slotin <andrew.slotin@grafana.com>
Lantero
left a comment
Lantero
left a comment
There was a problem hiding this comment.
I'll approve it content/product wise, I will let Heitor add the grammar/structure sprinkles 🙂
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
* add k6 binary provisioning preview Signed-off-by: Pablo Chacin <pablochacin@gmail.com> * port changes to v1.0.x Signed-off-by: Pablo Chacin <pablochacin@gmail.com> * skip snip Signed-off-by: Pablo Chacin <pablochacin@gmail.com> * Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com> Co-authored-by: Andrey Slotin <andrew.slotin@grafana.com> * skip running example script Signed-off-by: Pablo Chacin <pablochacin@gmail.com> * remove unnecessary code directives Signed-off-by: Pablo Chacin <pablochacin@gmail.com> * Update binary provisioning to fit style guide --------- Signed-off-by: Pablo Chacin <pablochacin@gmail.com> Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com> Co-authored-by: Andrey Slotin <andrew.slotin@grafana.com>
6 participants
What?
Add an introduction to the Binary Provisioning feature to be released as experimental feature in
v1.0.0Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)