-
Notifications
You must be signed in to change notification settings - Fork 231
Add k6 binary provisioning preview #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical content looks good to me. I assume @heitortsergent will handle grammar and formatting.
@heitortsergent, the code execution is failing. I tried to skip but it is still being executed. Can you please help me with this? 🙏 |
Content-wise, the PR LGTM. That said, given that the current state is the following:
Shouldn't this live in the Cloud docs? We could still have a reference in the extension sections... but yeah |
I believe it should and it might make sense to document it from the perspective of being able to use k6 extensions in Grafana Cloud. The CLI support of Binary Provisioning is there to match the Cloud experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased for readability.
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/v1.0.x/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small suggestions, but I'd like to change the structure a little bit so it follows our style guide. Do you mind if I make some changes directly to the branch @pablochacin?
We could also merge this after resolving the open comments, and I can made edits later if that's ok. 🤓
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
```windows-powershell | ||
|
||
``` | ||
|
||
```windows | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```windows-powershell | |
``` | |
```windows | |
``` |
Can we remove these since there are no specific commands for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heitortsergent I think there should be, because this is available for Windows users, only that I don't have a windows machine to test them
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <[email protected]> Co-authored-by: Andrey Slotin <[email protected]>
docs/sources/k6/next/extensions/run-extensions-using-binary-provisioning.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve it content/product wise, I will let Heitor add the grammar/structure sprinkles 🙂
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
What?
Add an introduction to the Binary Provisioning feature to be released as experimental feature in
v1.0.0
Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.docs/sources/k6/v{most_recent_release}
folder of the documentation.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)