Skip to content

Add k6 binary provisioning preview #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pablochacin
Copy link
Contributor

What?

Add an introduction to the Binary Provisioning feature to be released as experimental feature in v1.0.0

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

@pablochacin pablochacin requested review from heitortsergent and a team as code owners April 25, 2025 10:08
@pablochacin pablochacin requested review from mstoykov, inancgumus, codebien, Lantero and dgzlopes and removed request for a team, mstoykov and inancgumus April 25, 2025 10:08
Signed-off-by: Pablo Chacin <[email protected]>
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The technical content looks good to me. I assume @heitortsergent will handle grammar and formatting.

@pablochacin
Copy link
Contributor Author

pablochacin commented Apr 30, 2025

@heitortsergent, the code execution is failing. I tried to skip but it is still being executed. Can you please help me with this? 🙏

@dgzlopes
Copy link
Member

dgzlopes commented May 2, 2025

Content-wise, the PR LGTM. That said, given that the current state is the following:

The feature requires authentication to Grafana Cloud and therefore is supported only in the cloud run command.

Shouldn't this live in the Cloud docs? We could still have a reference in the extension sections... but yeah

@andrewslotin
Copy link
Contributor

@dgzlopes,

Shouldn't this live in the Cloud docs?

I believe it should and it might make sense to document it from the perspective of being able to use k6 extensions in Grafana Cloud. The CLI support of Binary Provisioning is there to match the Cloud experience.

Copy link
Contributor

@andrewslotin andrewslotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased for readability.

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small suggestions, but I'd like to change the structure a little bit so it follows our style guide. Do you mind if I make some changes directly to the branch @pablochacin?

We could also merge this after resolving the open comments, and I can made edits later if that's ok. 🤓

Comment on lines +64 to +69
```windows-powershell

```

```windows
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```windows-powershell
```
```windows
```

Can we remove these since there are no specific commands for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heitortsergent I think there should be, because this is available for Windows users, only that I don't have a windows machine to test them

Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Andrey Slotin <[email protected]>
Copy link

@Lantero Lantero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it content/product wise, I will let Heitor add the grammar/structure sprinkles 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants