Conversation
MattDodsonEnglish
left a comment
There was a problem hiding this comment.
Thanks so much for the dust up. I appreciate the commitment to that for unrestricted clauses. I thought I was the only one who cared about this important issue 😁
I just left some nits, the vast majority of which weren't even from the suggested changes, but just happened to be in the relevant lines.
Since these are all grammar and formatting, I'm going to say that we can merge this without Nicole's review. For any load testing related changes, though, it's definitely better to get a review from the experts.
| - Save the response to the request in Step 1. | ||
| - Extract the csrf token from Step 1. | ||
| - Pass the csrf token when requesting Step 2. | ||
| - Extract the [Cross-Site Request Forgery (CSFR)](https://owasp.org/www-community/attacks/csrf) token from Step 1. |
There was a problem hiding this comment.
| - Extract the [Cross-Site Request Forgery (CSFR)](https://owasp.org/www-community/attacks/csrf) token from Step 1. | |
| - Extract the [Cross-Site Request Forgery (CSFR)](https://owasp.org/www-community/attacks/csrf) token from Step 1. |
Is this the first place that CSFR appears? I think we might want to link it there, or not link unless it's necessary here. Generally, I try to avoid links in direct procedures, since links naturally call to themselves, which may divide the reader's attention.
Willing to change my opinion though if the info is particularly useful here.
There was a problem hiding this comment.
I think it was the first appearance, and for newcomers it's good to explain what this is (unless we had a glossary)
Matt's review Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
Note: I'm leaving for another PR the changes to https://github.com/grafana/k6-learn/blob/main/Modules/III-k6-Intermediate/08-Setting-load-profiles-with-executors/Ramping-Arrival-Rate-Exercises.md#autoscaling-of-virtual-users and https://github.com/grafana/k6-learn/blob/main/Modules/III-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md#autoscaling-of-virtual-users. We should probably discourage the use of
maxVUsin favor of allocating the required number of VUs, and explain the executor behavior a bit better here, and in the docs.